Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic Info FadeIn State #146

Merged
merged 22 commits into from
Jan 18, 2023
Merged

Basic Info FadeIn State #146

merged 22 commits into from
Jan 18, 2023
+112 −94

Conversation

Yashita101
Copy link
Contributor

No description provided.

@arunshenoy99 arunshenoy99 added WIP PR is a Work in Progress and not ready for review. Post Phase 2 Polish Polish PR's for work done in Phase 2 labels Jan 5, 2023
@arunshenoy99 arunshenoy99 changed the base branch from release/v1.0.0-polished to trunk January 5, 2023 17:25
@officiallygod officiallygod removed the WIP PR is a Work in Progress and not ready for review. label Jan 9, 2023
@officiallygod
Copy link
Member

Let's wait for PRESS 2-462 to be merged before we merge this Story, as this has changes from that story.

arunshenoy99
arunshenoy99 requested changes Jan 13, 2023
View reviewed changes
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending: Investigate if we can wait on the site logo to load as well instead of waiting only on flow and social API's

@officiallygod
Copy link
Member

Also, made changes to PRESS 2-462 to use an Animate component, please do make the changes accordingly and do provide any feedback or changes that further need to be made.

officiallygod

This comment was marked as resolved.

Sign in to view

@Yashita101
Copy link
Contributor Author

Pending: Investigate if we can wait on the site logo to load as well instead of waiting only on flow and social API's

The rendering of the image of the user depends on their internet speed, which is not possible to track via our code, as we can verify if the url is valid and not whether the rendering is complete. Hence this condition for siteLogo cannot be checked.

@arunshenoy99
Copy link
Member

Pending: Investigate if we can wait on the site logo to load as well instead of waiting only on flow and social API's

The rendering of the image of the user depends on their internet speed, which is not possible to track via our code, as we can verify if the url is valid and not whether the rendering is complete. Hence this condition for siteLogo cannot be checked.

Have some idea around tracking, will create a new story.

arunshenoy99
arunshenoy99 requested changes Jan 17, 2023
View reviewed changes
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yashita101 I just merged trunk into this branch to get a good idea of the changes and noticed something: can we please remove all the changes in src/OnboardingSPA/pages/Steps/Ecommerce/StepAddress/index.js? This change deletes Animate from StepAddress and we definitely need Animate in our address step.

arunshenoy99
arunshenoy99 approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will create a story with details to handle the site logo render.

@arunshenoy99 arunshenoy99 merged commit 39ee372 into trunk Jan 18, 2023
@arunshenoy99 arunshenoy99 deleted the add/PRESS2-466-Skeleton-State-Basic-Info branch January 18, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@officiallygod officiallygod officiallygod approved these changes

@arunshenoy99 arunshenoy99 arunshenoy99 approved these changes

Assignees
No one assigned
Labels
Post Phase 2 Polish Polish PR's for work done in Phase 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yashita101 @officiallygod @arunshenoy99